[import] Only strengthen references for imported items #1
Labels
Comments
rexxars
changed the title
|
Moving this to internal bugtracker |
ghost
mentioned this issue
rexxars
added a commit
that referenced
this issue
Sep 3, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
added a commit
that referenced
this issue
Sep 6, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
added a commit
that referenced
this issue
Sep 6, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
added a commit
that referenced
this issue
Sep 6, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
ricokahler
pushed a commit
that referenced
this issue
Sep 7, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
added a commit
that referenced
this issue
Sep 7, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
added a commit
that referenced
this issue
Sep 7, 2021
This is considered "the right way", as styled-components generally don't work well when there are multiple versions on the same page (because of mismatch in theme context providers, the provided theme values won't be available). This is step #1 - we'll have to actually make sure styled-components is installed in each studio (we can't strictly rely on npm7s peer dep behavior). That task will be handled by the Sanity CLI tool - we'll check on startup, build, deploy and similar whether or not we have the necessary dependencies installed, and prompt to install them if not.
rexxars
pushed a commit
that referenced
this issue
Jan 26, 2022
Use observables on low-level request, remove eventHandlers from SanityClient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running an import with the
--missingflag, we are still doing the unsetting of weak reference flags for every document, not just the ones that were missing.The text was updated successfully, but these errors were encountered: