Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview on macos+chrome fails to render #1375

Closed
thomax opened this issue Jun 18, 2019 · 4 comments · Fixed by #1380
Closed

Preview on macos+chrome fails to render #1375

thomax opened this issue Jun 18, 2019 · 4 comments · Fixed by #1380
Labels

Comments

@thomax
Copy link
Contributor

thomax commented Jun 18, 2019

<Preview /> will occasionally render links, but fail to render text. Likely because it thinks it's not on the screen?

(Currently) reproduced here https://example.studio.sanity.work/test/dashboard. The same behavior happens in search results.

In the dashboard widget instance, resizing the browser window might suddenly make the preview items render properly.

This bug has only been observed on the Chrome browser on macos (seen on Chrome v75.0.3770.90). FF on macos works fine, as does Chrome on windows.

@thomax thomax added the bug label Jun 18, 2019
@bjoerge
Copy link
Member

bjoerge commented Jun 18, 2019

Seems to happen after upgrading Chrome from 74 to 75 👀

@mornir
Copy link

mornir commented Jun 19, 2019

So I've updated my Chrome on Windows from 74 to 75 and I indeed get the same bug.
But I also noticed that it only occurs after passing a certain breakpoints (see video).
https://sanity-io-land.slack.com/archives/C9Z7RC3V1/p1560975853148800?thread_ts=1560936507.130700&cid=C9Z7RC3V1

@bjoerge
Copy link
Member

bjoerge commented Jun 19, 2019

It's most likely caused by this Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=972196

I'll see if I can find a workaround.

bjoerge added a commit that referenced this issue Jun 19, 2019
…tionobserver chromium bug

This fixes a bug recently introduced in Chromium and released in Chrome 75 which is causing the IntersectionObserverEntry.isIntersecting to report false on empty elements.

See issue #1375 and https://bugs.chromium.org/p/chromium/issues/detail?id=972196

Fixes #1375
bjoerge added a commit that referenced this issue Jun 19, 2019
…tionobserver chromium bug (#1380)

This is a workaround for a bug recently introduced in Chromium, released in Chrome 75 which is causing the `IntersectionObserverEntry.isIntersecting` to report `false` on empty elements. This again affected list previews in the Sanity Studio (see full description here:  #1375)

See also https://bugs.chromium.org/p/chromium/issues/detail?id=972196

Fixes #1375
@bjoerge
Copy link
Member

bjoerge commented Jun 19, 2019

This is hopefully fixed in v0.140.36. Please run sanity upgrade and let us know if the issue persist.

bjoerge added a commit that referenced this issue Aug 13, 2019
…tionobserver chromium bug (#1380)

This is a workaround for a bug recently introduced in Chromium, released in Chrome 75 which is causing the `IntersectionObserverEntry.isIntersecting` to report `false` on empty elements. This again affected list previews in the Sanity Studio (see full description here:  #1375)

See also https://bugs.chromium.org/p/chromium/issues/detail?id=972196

Fixes #1375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants