Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari reports valid urls as invalid #751

Closed
bjoerge opened this issue Apr 23, 2018 · 1 comment
Closed

Safari reports valid urls as invalid #751

bjoerge opened this issue Apr 23, 2018 · 1 comment

Comments

@bjoerge
Copy link
Member

bjoerge commented Apr 23, 2018

image

This happens in Safari 11.1
@bjoerge
Copy link
Member Author

bjoerge commented Apr 23, 2018 •
edited

Quite interesting. It looks like Safari looks at the length of arguments passed to the URL constructor, so new URL('http://foobar.com', undefined) will always throw.

bjoerge added a commit that referenced this issue Apr 23, 2018
@bjoerge
[validation] Fix wrong URL constructor invocation. Fixes #751
fd9123d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjoerge