Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components] Collapse pane when too narrow #1010

Merged
merged 1 commit into from
Oct 12, 2018
Merged

[components] Collapse pane when too narrow #1010

merged 1 commit into from
Oct 12, 2018

Conversation

kristofferjs
Copy link
Contributor

Fixes a bug that I think was introduced in "structure" where the pane does not collapse when resized smaller than minWidth

rexxars
rexxars approved these changes Oct 12, 2018
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified the pane lookup a bit, otherwise good!
Want to get this into the next release, so will merge on your behalf.

@rexxars rexxars merged commit ef06da3 into next Oct 12, 2018
@rexxars rexxars deleted the pane-collapse branch October 12, 2018 21:37
bjoerge pushed a commit that referenced this pull request Oct 16, 2018
@bjoerge
[components] Collapse pane when too narrow (#1010)
58a52de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristofferjs @rexxars