-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vision] Replace JSON viewer #1020
Conversation
packages/@sanity/vision/package.json
Outdated
@@ -27,6 +27,7 @@ | |||
"react-codemirror2": "^1.0.0", | |||
"react-icon-base": "^2.1.2", | |||
"react-json-inspector": "^7.1.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we still using react-json-inspector or can it be removed now?
) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing newline here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
This replaces the JS(ON)-viewer in Vision with the [react-json-view](https://www.npmjs.com/package/react-json-view) component. The previous had formatting errors (strings in arrays). This also features a copy-function so that you can actually get sensible data out of vision. [vision] Fix visual hover bug
This replaces the JS(ON)-viewer in Vision with the react-json-view component. The previous had formatting errors (strings in arrays). This also features a copy-function so that you can actually get sensible data out of vision.