Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpack-loader] Peg loader-utils at 1.1.0 #1142

Merged
merged 1 commit into from
Dec 25, 2018
Merged

Conversation

evenwestvang
Copy link
Member

Webpack's loader-utils was upgraded today with the result that some of our CSS stopped loading / building. The end result is that text fields and all popups loose some crucial styling. 馃帀

image

Comparing all updated packages to a local last known good narrowed the list of candidate packages down and the problem went away when pinning loader-utils to 1.1.0.

I have an hunch it might be this fix causing the issues:

isUrlRequest: ignore all url with extension (like moz-extension:, ms-browser-extension: and etc)

Didn't dig after root causes or an explanation for why it doesn't clobber all CSS parts.

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@rexxars rexxars merged commit 4787bb1 into next Dec 25, 2018
@rexxars rexxars deleted the fix-failing-css-builds branch December 25, 2018 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants