Fix/title push icons outside mobile view #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariuslundgard
approved these changes
Feb 18, 2019
kristofferjs
pushed a commit
that referenced
this pull request
Feb 19, 2019
* [default-layout] Ellipsis on mobile title * [test] Approve reference images
bjoerge
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [default-layout] Ellipsis on mobile title * [test] Approve reference images
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [default-layout] Ellipsis on mobile title * [test] Approve reference images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where long titles pushed icons outside the viewport.
We need to re-visit the responsive measuring done in the delightful project to get bullet proof responsive layout. The title still ellipses on very wide screens prioritising a very large search field.