[default-layout] Reset tool when selecting active tool #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
reset-tool-when-clicking-existing
branch
3 times, most recently
from
d069a8c
to
de297cc
Compare
bjoerge
force-pushed
the
reset-tool-when-clicking-existing
branch
from
de297cc
to
4cce3d3
Compare
|
Looks good! I did a tiny rewrite in order to make it more future proof by having less assumptions about which router state keys might or might not be present. |
bjoerge
approved these changes
Feb 15, 2019
kristofferjs
pushed a commit
that referenced
this pull request
Feb 19, 2019
* [default-layout] Reset tool when selecting existing * [default-layout] Reset tool router in a less assumptious way
bjoerge
pushed a commit
that referenced
this pull request
Mar 6, 2019
* [default-layout] Reset tool when selecting existing * [default-layout] Reset tool router in a less assumptious way
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [default-layout] Reset tool when selecting existing * [default-layout] Reset tool router in a less assumptious way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on the current active tool it is expected that the tool resets to its initial state.
Let me know if this is an ok way of doing it.