Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Show stack traces on errors by default #1202

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Feb 6, 2019

At some point we (I?) decided that not showing stack traces on errors would be "cleaner" for regular users. After trying to debug problems with our users for a while, I feel perhaps it is saner to display a stacktrace so we can more easily track down the source of problems. This is especially true on intermittent errors that are not reproducible when re-running with the -d flag.

@kmelve
Copy link
Member

kmelve commented Feb 6, 2019

Would it be possible to have “both”, i.e. make the error message easily identified and readable, in addition to having the stack trace available? I agree that would make support a bit easier, which is good for all parties.

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rexxars
Copy link
Member Author

rexxars commented Feb 15, 2019

Would it be possible to have “both”, i.e. make the error message easily identified and readable, in addition to having the stack trace available? I agree that would make support a bit easier, which is good for all parties.

I'm not sure how you mean.

Error: Some descriptive error here
  at someSourceLocation.js:123
  at someSourceLocation.js:321
  at someSourceLocation.js:19
  at someSourceLocation.js:25

How do you want this to be printed, @kmelve ?

@kmelve
Copy link
Member

kmelve commented Feb 15, 2019

In my experience, people tend to miss the actual error in stack traces because they're confronted with a bunch of text. Some simple formatting/whitespace between the error message and the trace would alleviate that.

Error: Some descriptive error here

  at someSourceLocation.js:123
  at someSourceLocation.js:321
  at someSourceLocation.js:19
  at someSourceLocation.js:25

@rexxars
Copy link
Member Author

rexxars commented Feb 15, 2019

How about using something like this?

@rexxars rexxars merged commit b2ab56a into next Mar 5, 2019
@rexxars rexxars deleted the cli-stack-by-default branch March 5, 2019 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants