Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block editor dialog title #1226

Merged
merged 3 commits into from
Mar 6, 2019
Merged

Block editor dialog title #1226

merged 3 commits into from
Mar 6, 2019

Conversation

kristofferjs
Copy link
Contributor

  • Use DialogContent to set the size of the content
  • Set title on dialogs on block editor to the type title

Before:
screenshot 2019-03-04 at 13 25 16

After:
screenshot 2019-03-04 at 13 20 38

@kristofferjs kristofferjs added the ux label Mar 4, 2019
@kmelve
Update packages/@sanity/form-builder/src/inputs/BlockEditor/EditNode.js
ac256e0 
Co-Authored-By: kristofferj <kristoffer@sanity.io>
skogsmaskin
skogsmaskin approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bjoerge
bjoerge approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

rexxars
rexxars approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kristofferjs kristofferjs merged commit 75d019a into next Mar 6, 2019
@kristofferjs kristofferjs deleted the block-editor-dialog-title branch March 6, 2019 09:25
bjoerge pushed a commit that referenced this pull request Mar 6, 2019
@bjoerge
Block editor dialog title (#1226)
5c79081 
* [components] Same title on popover as default dialog

* [form-builder] Show type title in diaog header instead of "edit"

* Update packages/@sanity/form-builder/src/inputs/BlockEditor/EditNode.js

Co-Authored-By: kristofferj <kristoffer@sanity.io>
mariuslundgard pushed a commit that referenced this pull request Mar 10, 2019
@mariuslundgard
Block editor dialog title (#1226)
a33f6ca 
* [components] Same title on popover as default dialog

* [form-builder] Show type title in diaog header instead of "edit"

* Update packages/@sanity/form-builder/src/inputs/BlockEditor/EditNode.js

Co-Authored-By: kristofferj <kristoffer@sanity.io>
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@bjoerge
Block editor dialog title (#1226)
1c114ec 
* [components] Same title on popover as default dialog

* [form-builder] Show type title in diaog header instead of "edit"

* Update packages/@sanity/form-builder/src/inputs/BlockEditor/EditNode.js

Co-Authored-By: kristofferj <kristoffer@sanity.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexxars rexxars rexxars approved these changes

@skogsmaskin skogsmaskin skogsmaskin approved these changes

@bjoerge bjoerge bjoerge approved these changes

@kmelve kmelve kmelve approved these changes

@mariuslundgard mariuslundgard Awaiting requested review from mariuslundgard

Assignees
No one assigned
Labels
ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kristofferjs @rexxars @skogsmaskin @bjoerge @kmelve