Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[form-builder] Block editor: hide 'More' button if empty #1247

Merged
merged 1 commit into from
Mar 22, 2019
Merged

[form-builder] Block editor: hide 'More' button if empty #1247

merged 1 commit into from
Mar 22, 2019

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Mar 20, 2019 •
edited

Don't show link to more in the editor toolbar if there isn't more to actually show (very restricted editor feature-set).

kristofferjs
kristofferjs approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skogsmaskin skogsmaskin merged commit 0e63be0 into next Mar 22, 2019
@skogsmaskin skogsmaskin deleted the fix-editor-empty-more-button branch March 22, 2019 10:25
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@skogsmaskin @bjoerge
[form-builder] Block editor: hide 'More' button if empty (#1247)
f8b76b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs kristofferjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skogsmaskin @kristofferjs