Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[form-builder] Pass on markers from asset inputs to fieldset #1281

Merged
merged 1 commit into from Apr 30, 2019
Merged

[form-builder] Pass on markers from asset inputs to fieldset #1281

merged 1 commit into from Apr 30, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Apr 29, 2019

Image and file fields were not getting their markers displayed because they were not passed down to the fieldset. This fixes that, making validation status more prominent.

kristofferjs
kristofferjs approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (Did not test locally)

@rexxars rexxars removed the request for review from bjoerge April 30, 2019 08:54
@rexxars rexxars merged commit bb1716c into next Apr 30, 2019
@rexxars rexxars deleted the asset-field-markers branch April 30, 2019 08:54
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@rexxars @bjoerge
[form-builder] Pass on markers from asset inputs to fieldset (#1281)
69e9421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs kristofferjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rexxars @kristofferjs