[form-builder] Hide image edit button if no fields and no asset #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
force-pushed
the
image-hide-edit-when-no-asset
branch
from
4f104da
to
26b065a
Compare
rexxars
changed the title
kristofferjs
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an image field where all the fields are "hoisted"/"highlighted" to always be shown and the hotspot tool is enabled, the edit button is shown. If however the field does not have any asset, the dialog shows nothing but a header.
With this PR, we only show the edit button if the image has non-hoisted fields, OR the image field both has an asset and has hotspot enabled.