[client] Raise default timeout, allow overriding per-request #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SGTM. It might be worth differentiating between request timeouts and network timeouts, if possible. The initial TCP connection handshake should have a much lower timeout (e.g. 10 seconds or something reasonable), but the response timeout should be above our operation timeouts. |
erikgrinaker
approved these changes
May 2, 2019
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [client] Raise default timeout to 5 minutes * [client] Allow overriding timeout + token per-request
rexxars
added a commit
that referenced
this pull request
Jan 26, 2022
* [client] Raise default timeout to 5 minutes * [client] Allow overriding timeout + token per-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that the default timeout is above the technical limits (5 minutes, vs 3 minute mutation and 1 minute query timeout). This will lead to more understandable error messages on timeouts, and being able to more easily differentiate between client and server timeouts.
Also added the ability to override timeout and token on a per-request basis, which can be quite useful in a lot of situations.