Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[form-builder] Display "no images found" text if no images are found #1306

Merged
merged 1 commit into from
May 20, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented May 20, 2019

If no images are found, we just show an empty dialog with the title "Select image". This adds a (minimal) message to let you know what's going on.

@rexxars rexxars requested a review from kristofferjs May 20, 2019 10:02
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could possibly style this better. Will make another issue for that

@rexxars rexxars merged commit cdc30a1 into next May 20, 2019
@rexxars rexxars deleted the image-select-no-imgs-found branch May 20, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants