[mutator] Use strict equals when comparing equality #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
changed the title
kristofferjs
pushed a commit
that referenced
this pull request
May 23, 2019
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the object:
{attr: "123"}The following expression matches in the mutators JSONPath implementation:
[attr==123]While in the Sanity DB, it does not (should be
[attr=="123"]).The error was simply not using a strict equality check when evaluating the expression.
This PR fixes this and adds tests for this case.
Over-the-shoulder, IRL-approved by @simen