[form-builder] Constrain rendered images to a reasonable size #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
changed the title
bjoerge
pushed a commit
that referenced
this pull request
Aug 13, 2019
* [imagetool] Expose max height / max width used in image tool * [form-builder] Constrain rendered images to a reasonable size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image input renders the full-size image, which can be quite expensive in terms of both bandwidth and CPU/memory usage.
While the optimal thing to do may be to constrain it to the size of the container, that can quickly yield a myriad of different variations based on the client. Instead, we constrain it to the max size that the image tool (the crop/hotspot editor) will use, currently 1000px in width. We also factor in the DPR, scaling it up if the device supports it.
It's a bit convoluted, but I think this is the best I can come up with within a reasonable timeframe. Better than 20 MB jpegs, I guess? ;)