Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base] Use pre-wrap to constrain width when displaying uncaught errors #1343

Merged
merged 1 commit into from
May 31, 2019
Merged

[base] Use pre-wrap to constrain width when displaying uncaught errors #1343

merged 1 commit into from
May 31, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented May 31, 2019

(This is actually @kristofferj's work, I just put it into a commit)

@rexxars rexxars requested a review from kristofferjs May 31, 2019 08:22
kristofferjs
kristofferjs approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rexxars rexxars merged commit 10f9130 into next May 31, 2019
@rexxars rexxars deleted the wrap-errs branch May 31, 2019 10:57
bjoerge pushed a commit that referenced this pull request Aug 13, 2019
@rexxars @bjoerge
[base] Use pre-wrap to constrain width when displaying uncaught errors (
383484c 
#1343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs kristofferjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rexxars @kristofferjs