Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[components] fix errors disappearing too fast #1457

Merged
merged 1 commit into from
Aug 26, 2019
Merged

[components] fix errors disappearing too fast #1457

merged 1 commit into from
Aug 26, 2019

Conversation

vicmeow
Copy link
Contributor

@vicmeow vicmeow commented Aug 22, 2019

Currently some snackbars disappear too fast, particularly errors.

  • Increased the default dismiss timeout (4s -> 5s)
  • Increased the timeout for error snackbars (4s -> 8s)

@vicmeow vicmeow added the ux label Aug 22, 2019
@vicmeow vicmeow closed this Aug 22, 2019
@vicmeow vicmeow reopened this Aug 22, 2019
kristofferjs
kristofferjs approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@kristofferjs kristofferjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@vicmeow vicmeow merged commit 5664709 into next Aug 26, 2019
@vicmeow vicmeow deleted the snackbar-dismissal branch August 26, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristofferjs kristofferjs kristofferjs approved these changes

@bjoerge bjoerge bjoerge approved these changes

Assignees
No one assigned
Labels
ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vicmeow @kristofferjs @bjoerge