Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization issues #1549

Merged
merged 5 commits into from
Oct 15, 2019
Merged

Fix serialization issues #1549

merged 5 commits into from
Oct 15, 2019

Conversation

skogsmaskin
Copy link
Member

@skogsmaskin skogsmaskin commented Oct 15, 2019

This will a couple of HTML deserialization and PT normalization issues.

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to get a full picture here, but looks good from the surface!

@skogsmaskin skogsmaskin merged commit b534a90 into next Oct 15, 2019
@skogsmaskin skogsmaskin deleted the fix-serialization-issues branch October 15, 2019 16:42
skogsmaskin added a commit that referenced this pull request Oct 17, 2019
* [block-tools] Fix serialization issue with reducing spans in normalizeBlock

Also removes leftover markDefs when normalizing

* [form-builder] Block editor: add remove link test

* [block-tools] Remove text nodes within list containers

* [block-tools] Better test for if the text node is valid or should be ingored

* [block-tools] Update tests
skogsmaskin added a commit that referenced this pull request Oct 17, 2019
* [block-tools] Fix serialization issue with reducing spans in normalizeBlock

Also removes leftover markDefs when normalizing

* [form-builder] Block editor: add remove link test

* [block-tools] Remove text nodes within list containers

* [block-tools] Better test for if the text node is valid or should be ingored

* [block-tools] Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants