Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add installation instructions for Google Maps plugin #1566

Merged
merged 1 commit into from Oct 28, 2019
Merged

Add installation instructions for Google Maps plugin #1566

merged 1 commit into from Oct 28, 2019

Conversation

kmelve
Copy link
Member

@kmelve kmelve commented Oct 25, 2019

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

Description

This improves the README.md of the Google Maps input plugin with installation instructions, and to get the API key.

Note for release

This PR adds more helpful instructions for how to use this plugin.

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@kmelve kmelve marked this pull request as ready for review October 25, 2019 08:51
@kmelve kmelve changed the title Add installation instructions Add installation instructions for Google Maps plugin Oct 25, 2019
@kmelve
Copy link
Member Author

kmelve commented Oct 25, 2019

Sorry about the borked branch-name (I did this on GitHub)

skogsmaskin
skogsmaskin approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kmelve kmelve merged commit ec6271b into next Oct 28, 2019
@rexxars rexxars deleted the google-maps-improve-maps branch February 14, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skogsmaskin skogsmaskin skogsmaskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kmelve @skogsmaskin