Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[desk-tool] Wrap EditorPane and use document id as key to force reload #1601

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Nov 14, 2019

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior
When switching between documents from the search bar (and with no document list panes open), the portable text editor retains the value from the previous document.

Description
I wasn't able to figure out the root cause, but this PR at least provides a quickfix by changing the key for EditorPane, triggering an unmount + remount with new id.

Note for release

This provides a fix for a bug that affected portable text fields: When switching between documents from the search bar (and with no document list panes open), the portable text editor would retain the value from the previous document.

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@bjoerge bjoerge merged commit 16b501e into next Nov 14, 2019
@bjoerge bjoerge deleted the add-document-id-as-key-to-editorpane branch November 14, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants