Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add a tag option when interacting with GraphQL endpoints #1606

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

saasen
Copy link
Contributor

@saasen saasen commented Nov 18, 2019

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

The CLI defaults to use the default tag when deploying GraphQL endpoints.

Description

When migrating schemas, it's very useful to specify a custom tag and not break the existing endpoint.

This PR only merges to the gql-tag-option as there's more to do in regards to handle error messages from the GraphQL service.

Note for release

This change makes it possible for developers to provide a custom tag when deploying their GraphQL endpoints. This to either migrating to a new endpoint if the new schema contains breaking changes.

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@saasen saasen requested a review from rexxars November 18, 2019 19:51
@rexxars rexxars changed the base branch from gql-tag-option to gql-v2 December 16, 2019 10:37
@rexxars rexxars changed the title WIP: [core] Add a tag option when interacting with GraphQL endpoints [core] Add a tag option when interacting with GraphQL endpoints Dec 16, 2019
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Merging into a feature branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants