Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[structure] Try to infer schema type from filter in document lists #1634

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Nov 27, 2019

As outlined in #1633, the following structure does not get a schema type set:

S.documentList()
  .title('Unspecified books list')
  .menuItems(S.documentTypeList('book').getMenuItems())
  .filter('_type == $type')
  .params({type: 'book'})

While this shouldn't normally cause any problems, in this case we can actually infer it based on the filter/parameter, which saves us from having to resolve it further down the stack.

@rexxars rexxars force-pushed the infer-document-list-schema-type branch from 435edb8 to d6b8b9e Compare November 28, 2019 01:16
Copy link
Contributor

@thomax thomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants