Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add template for custom asset source plugin #1639

Merged
merged 1 commit into from
Nov 28, 2019

Conversation

vicmeow
Copy link
Contributor

@vicmeow vicmeow commented Nov 28, 2019

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

Description

Adds a template that makes it easier to get started with creating a custom asset source plugin!

Note for release

  • Create asset source plugins from the CLI with sanity init plugin and select the custom asset source option

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@vicmeow vicmeow requested a review from kmelve November 28, 2019 08:36
Copy link
Member

@kmelve kmelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

It would be nice if you included a button with the props.onSelect() handler with an example image in the plugin template. That way developers can get a feel for how it actually works right away.

@skogsmaskin
Copy link
Member

Great @vicbergquist! Yes, would be nice with a actual working one. There is a simple example in the docs with a Octocat image.

@vicmeow
Copy link
Contributor Author

vicmeow commented Nov 28, 2019

Great work! It would be nice if you included a button with the props.onSelect() handler with an example image in the plugin template. That way developers can get a feel for how it actually works right away.

Great @vicbergquist! Yes, would be nice with a actual working one. There is a simple example in the docs with a Octocat image.

Done!

@vicmeow vicmeow requested a review from kmelve November 28, 2019 09:49
Copy link
Member

@kmelve kmelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants