[chore] Migrate storybook dependencies #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
force-pushed
the
chore/migrate-storybook
branch
from
dcfb1c8
to
5132adb
Compare
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
7b58bd2
to
92307e1
Compare
bjoerge
force-pushed
the
next
branch
2 times, most recently
from
b8c7301
to
84d823c
Compare
bjoerge
force-pushed
the
chore/migrate-storybook
branch
2 times, most recently
from
5b9808b
to
7272a1a
Compare
* [vision] Fix issue where incorrect dataset would be chosen * [vision] Show query URL with copy button
* [test-studio] Update test-studio schema with language alternatives * [code-input] Make code-input slightly more configurable
…e schema as prop (#213) * [form-builder] Extract FormBuilderContext and let WithFormBuilder take schema as prop * [form-builder] Pass value to FormbuilderContext and be explicit about the state keys passed to child component
|
Can you rebase this against next? |
|
Sure |
bjoerge
force-pushed
the
chore/migrate-storybook
branch
from
7272a1a
to
6356334
Compare
|
Closing this as it's rolled into the webpack 3 PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP - not ready for merge]
A lot has happened with storybook lately. We should try to keep up, so I've started by changing the packages names. I hit the wall with the webpack config and could not figure out how to get it to work. It may have something to do with webpack v1 vs v2 config format? If I could get some help with the webpack config, I can go ahead and migrate the rest of the code if needed (I suspect there may be a few things that needs to be done with our custom knobs addon, etc.)