Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[default-layout] Hints mode #1660

Merged
merged 128 commits into from
Dec 12, 2019
Merged

[default-layout] Hints mode #1660

merged 128 commits into from
Dec 12, 2019

Conversation

thomax
Copy link
Contributor

@thomax thomax commented Dec 12, 2019

This PR adds an open/close-able tray (aka side-car) to default layout and an interface to control what's rendered inside. Also, a new plugin @sanity/studio-hints implements this part and introduces hints which are hopefully useful to Studio developers just starting out.

There's some commented out code in @sanity/studio-hints which will do an appearance shortly.

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No (not yet, this will be a non-public feature for the time being)

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@thomax thomax changed the title Hints mode [default-layout] Hints mode Dec 12, 2019
Copy link
Member

@skogsmaskin skogsmaskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @bjoerge's comments are attended to, I approve of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants