Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Check for breaking changes when deploying GraphQL API #1701

Merged
merged 2 commits into from
Jan 22, 2020

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Jan 15, 2020

This adds validation logic to the GraphQL API deployment, ensuring that the user is made aware of any dangerous or breaking changes.

If any dangerous changes are found, a confirmation dialog is shown. A new flag, --force can be used to blindly overwrite the API (useful for CI flows etc).

@rexxars rexxars requested a review from saasen January 15, 2020 21:29
Copy link
Contributor

@saasen saasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM. 👍

@rexxars rexxars merged commit 0d05861 into gql-v2 Jan 22, 2020
@rexxars rexxars deleted the gql-breaking-deploy-check branch January 22, 2020 17:41
rexxars added a commit that referenced this pull request Jan 30, 2020
* [core] Check for dangerous/breaking changes when deploying GraphQL schemas

* [core] Include tag in confirm message when undeploying GraphQL API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants