New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[desk-tool] Refactor file organization (chore) #1846
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/sanity-io/test-studio/aek25sact |
85ff1e7
to
591c3da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but isn't it nicer to keep CSS files in a styles folder so that the components folder doesn't get too cluttered/long?
@vicbergquist I changed that because I find it quicker to jump between the CSS file and the JS file if they are in the same directory. I consider both CSS and JS to be the component, so think it should be in one place. If components list gets too long, it can be divided into subfolders? |
@mariuslundgard ok makes sense! 👍 |
Good! If we later find that using |
Type of change (check at least one)
Does this change require a documentation update? (Check one)
Current behavior
n/a
Description
These changes include moving around React components and CSS files to fit into the following structure:
Note for release
n/a
Checklist
[some-package] PR title (#123)