Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base] Update default CSS variables #1867

Merged
merged 7 commits into from
May 19, 2020
Merged

[base] Update default CSS variables #1867

merged 7 commits into from
May 19, 2020

Conversation

mariuslundgard
Copy link
Member

@mariuslundgard mariuslundgard commented May 4, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe: Improvement / design update.

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

The default Studio theme does not use the Sanity color scheme.

Description

The CSS variables now use the Sanity color schema, by overriding specific values in the override.css file.

Test script

  • Try to find bugs related to colors and spacing
  • See how everything works with custom themes by adding an override to packages/test-studio/sanity.json:
    {
      "implements": "part:@sanity/base/theme/variables/override-style",
      "path": "src/themes/dark.css"
    }

// or

    {
      "implements": "part:@sanity/base/theme/variables/override-style",
      "path": "src/themes/hotdog.css"
    }

Note for release

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@vercel
Copy link

vercel bot commented May 4, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/1e5pwpozm
✅ Preview: https://test-studio-git-base-update-colors.sanity-io.now.sh

@vercel vercel bot temporarily deployed to Preview May 8, 2020 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview May 8, 2020 11:50 Inactive
@mariuslundgard mariuslundgard changed the title [base] Update colors (work-in-progress) [base] Update colors May 8, 2020
@mariuslundgard mariuslundgard changed the title [base] Update colors [base] Update default CSS variables May 8, 2020
@vercel vercel bot temporarily deployed to Preview May 8, 2020 13:43 Inactive
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants