-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[components] Prevent fieldset grid blowout and fix related layout issues #1885
Merged
mariuslundgard
merged 8 commits into
next
from
components-prevent-fieldset-grid-blowout
May 19, 2020
Merged
[components] Prevent fieldset grid blowout and fix related layout issues #1885
mariuslundgard
merged 8 commits into
next
from
components-prevent-fieldset-grid-blowout
May 19, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sanity-io/test-studio/139o97mvf |
mariuslundgard
changed the title
Components prevent fieldset grid blowout
Prevent fieldset grid blowout
May 18, 2020
mariuslundgard
changed the title
Prevent fieldset grid blowout
Prevent fieldset grid blowout and related layout issues
May 18, 2020
mariuslundgard
changed the title
Prevent fieldset grid blowout and related layout issues
Prevent fieldset grid blowout and fix related layout issues
May 18, 2020
mariuslundgard
changed the title
Prevent fieldset grid blowout and fix related layout issues
[components] Prevent fieldset grid blowout and fix related layout issues
May 18, 2020
mariuslundgard
force-pushed
the
components-prevent-fieldset-grid-blowout
branch
from
May 18, 2020 12:15
c73a223
to
490842b
Compare
mariuslundgard
force-pushed
the
components-prevent-fieldset-grid-blowout
branch
from
May 18, 2020 13:06
6fc353c
to
e3be2c0
Compare
mariuslundgard
force-pushed
the
components-prevent-fieldset-grid-blowout
branch
from
May 19, 2020 10:14
e3be2c0
to
edd3fcf
Compare
mariuslundgard
force-pushed
the
components-prevent-fieldset-grid-blowout
branch
from
May 19, 2020 10:22
3a5eace
to
666f7db
Compare
mariuslundgard
force-pushed
the
components-prevent-fieldset-grid-blowout
branch
from
May 19, 2020 10:36
8ced19a
to
81d67fa
Compare
bjoerge
approved these changes
May 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change (check at least one)
Does this change require a documentation update? (Check one)
Current behavior
Description
grid-template-columns: minmax(0, 1fr);
on the various places that form fields are spaced.0
when providing it with the propertysubtitle={0}
.spotifyEmbed
type for testing.Note for release
Checklist
[some-package] PR title (#123)