Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] Prevent fieldset grid blowout and fix related layout issues #1885

Merged
merged 8 commits into from
May 19, 2020

Conversation

mariuslundgard
Copy link
Member

@mariuslundgard mariuslundgard commented May 18, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

  • Jørn reported that grid blowout still happens within PTE content.
  • Discovered that it's caused by a case in CSS grids called "grid blowout" (see post by Chris Coyier).

Description

  • Added grid-template-columns: minmax(0, 1fr); on the various places that form fields are spaced.
  • While working on this (and testing throughly), I discovered several related layout issues.
  • Fixed an issue in DefaultPreview where it would render an unstyled 0 when providing it with the property subtitle={0}.
  • Added spotifyEmbed type for testing.

Note for release

  • Prevent fieldset grid blowout and fix related layout issues

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@vercel
Copy link

vercel bot commented May 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/139o97mvf
✅ Preview: https://test-studio.now.sh

@mariuslundgard mariuslundgard changed the title Components prevent fieldset grid blowout Prevent fieldset grid blowout May 18, 2020
@mariuslundgard mariuslundgard changed the title Prevent fieldset grid blowout Prevent fieldset grid blowout and related layout issues May 18, 2020
@mariuslundgard mariuslundgard changed the title Prevent fieldset grid blowout and related layout issues Prevent fieldset grid blowout and fix related layout issues May 18, 2020
@mariuslundgard mariuslundgard changed the title Prevent fieldset grid blowout and fix related layout issues [components] Prevent fieldset grid blowout and fix related layout issues May 18, 2020
@mariuslundgard mariuslundgard force-pushed the components-prevent-fieldset-grid-blowout branch from c73a223 to 490842b Compare May 18, 2020 12:15
@mariuslundgard mariuslundgard marked this pull request as ready for review May 18, 2020 12:29
@vercel vercel bot temporarily deployed to Preview May 18, 2020 13:05 Inactive
@mariuslundgard mariuslundgard force-pushed the components-prevent-fieldset-grid-blowout branch from 6fc353c to e3be2c0 Compare May 18, 2020 13:06
@mariuslundgard mariuslundgard force-pushed the components-prevent-fieldset-grid-blowout branch from e3be2c0 to edd3fcf Compare May 19, 2020 10:14
@vercel vercel bot temporarily deployed to Preview May 19, 2020 10:14 Inactive
@mariuslundgard mariuslundgard force-pushed the components-prevent-fieldset-grid-blowout branch from 3a5eace to 666f7db Compare May 19, 2020 10:22
@vercel vercel bot temporarily deployed to Preview May 19, 2020 10:22 Inactive
Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@mariuslundgard mariuslundgard merged commit 13b7a02 into next May 19, 2020
@bjoerge bjoerge deleted the components-prevent-fieldset-grid-blowout branch May 19, 2020 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants