[chore] Fix eslint so it uses a common config for packages #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sanity-io/test-studio/oi9594739 |
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
1d7e3c1
to
6f68507
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
6f68507
to
964e3c8
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
964e3c8
to
878742d
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
878742d
to
8db0509
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
8db0509
to
18187f9
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
18187f9
to
c3f5555
Compare
rexxars
reviewed
May 20, 2020
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
c3f5555
to
c0cf4eb
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
c0cf4eb
to
7576cdc
Compare
|
Update: did some changes because the |
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
7576cdc
to
999912d
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
999912d
to
29e7736
Compare
mariuslundgard
force-pushed
the
chore-fix-eslint
branch
from
cc56dcd
to
ca1f10e
Compare
… all) - Use a single configuration for all source files (typescript/javascript) - Use the @typescript/eslint-parser for everything - Using sanity-eslint to typescript config too - Disable the '@typescript/no-use-before-define' rule - Disable the 'react/no-multi-comp' rule - Disable the 'react/require-optimization' rule - Disable the 'import/prefer-default-export' rule - Disabling 'import/no-commonjs' in favor of '@typescript-eslint/no-var-requires' - Allow commonjs in certain packages by disabling '@typescript-eslint/no-var-requires'
bjoerge
added a commit
that referenced
this pull request
Jun 8, 2020
* [chore] Fix eslint so it uses a common config for packages * [chore] Add JS extensions to lint command * [chore] Move eslint extends config in order to apply correct order of rules * [chore] Postpone introduction of eslint-plugin-react-hooks * [chore] Simplify proposed eslint setup a bit (one config to rule them all) - Use a single configuration for all source files (typescript/javascript) - Use the @typescript/eslint-parser for everything - Using sanity-eslint to typescript config too - Disable the '@typescript/no-use-before-define' rule - Disable the 'react/no-multi-comp' rule - Disable the 'react/require-optimization' rule - Disable the 'import/prefer-default-export' rule - Disabling 'import/no-commonjs' in favor of '@typescript-eslint/no-var-requires' - Allow commonjs in certain packages by disabling '@typescript-eslint/no-var-requires' Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
mariuslundgard
added a commit
that referenced
this pull request
Jun 9, 2020
* [chore] Fix eslint so it uses a common config for packages * [chore] Add JS extensions to lint command * [chore] Move eslint extends config in order to apply correct order of rules * [chore] Postpone introduction of eslint-plugin-react-hooks * [chore] Simplify proposed eslint setup a bit (one config to rule them all) - Use a single configuration for all source files (typescript/javascript) - Use the @typescript/eslint-parser for everything - Using sanity-eslint to typescript config too - Disable the '@typescript/no-use-before-define' rule - Disable the 'react/no-multi-comp' rule - Disable the 'react/require-optimization' rule - Disable the 'import/prefer-default-export' rule - Disabling 'import/no-commonjs' in favor of '@typescript-eslint/no-var-requires' - Allow commonjs in certain packages by disabling '@typescript-eslint/no-var-requires' Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
rexxars
pushed a commit
that referenced
this pull request
Jan 26, 2022
* [chore] Fix eslint so it uses a common config for packages * [chore] Add JS extensions to lint command * [chore] Move eslint extends config in order to apply correct order of rules * [chore] Postpone introduction of eslint-plugin-react-hooks * [chore] Simplify proposed eslint setup a bit (one config to rule them all) - Use a single configuration for all source files (typescript/javascript) - Use the @typescript/eslint-parser for everything - Using sanity-eslint to typescript config too - Disable the '@typescript/no-use-before-define' rule - Disable the 'react/no-multi-comp' rule - Disable the 'react/require-optimization' rule - Disable the 'import/prefer-default-export' rule - Disabling 'import/no-commonjs' in favor of '@typescript-eslint/no-var-requires' - Allow commonjs in certain packages by disabling '@typescript-eslint/no-var-requires' Co-authored-by: Bjørge Næss <bjoerge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.eslintrc.jsfor all packages, no matter if they include JS or TS or both (no need to add a.eslintrcin the packages that extends the root config).eslint-plugin-react-hooks.