Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[desk-tool] Fallback to ResizeObserver polyfill #1888

Merged
merged 1 commit into from
May 20, 2020

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented May 19, 2020

We are currently using a resize observer polyfill even in environments where it's natively supported. I propose we use a polyfill as a fallback instead. I also updated to a more recent polyfill that seems to be more aligned with the spec than the one we currently use.

Note for release
N/A

@bjoerge bjoerge requested a review from thomax May 19, 2020 16:07
@vercel
Copy link

vercel bot commented May 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/1swgnd7u4
✅ Preview: https://test-studio-git-conditionally-polyfill-resize-observer.sanity-io.now.sh

@bjoerge bjoerge requested a review from rexxars May 19, 2020 16:08
@bjoerge bjoerge marked this pull request as ready for review May 19, 2020 16:08
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjoerge bjoerge merged commit 173d989 into next May 20, 2020
@bjoerge bjoerge deleted the conditionally-polyfill-resize-observer branch May 20, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants