Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[client] Typings: Fix patch() signature not accepting patch instance #1894

Merged
merged 1 commit into from
May 27, 2020

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented May 26, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

You're currently not allowed by the typescript definitions to pass a Patch instance to a Transaction, eg trx.patch(somePatchInstance)

Description

This PR declares a separate method overload for the case where you pass it a patch instance instead of a document ID + patch builder/patch operations bundle.

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@vercel
Copy link

vercel bot commented May 26, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/cmdbpcckx
✅ Preview: https://test-studio-git-fix-patch-decl.sanity-io.now.sh

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rexxars rexxars merged commit 77f7539 into next May 27, 2020
@rexxars rexxars deleted the fix-patch-decl branch May 27, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants