Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Do not require authed user for sanity start #2027

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Sep 25, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

When you run sanity start without being authenticated in the CLI, it'll tell you:

Error: You must login first - run "sanity login"

...which is weird, as there are no API interactions to start up a development server

Description

This PR passes a flag to the client wrapper telling it that the command does not require an authenticated user.

Note for release

  • Fixed sanity start giving error if CLI had no locally authenticated user

Checklist

  • I have read the Contributing Guidelines
  • The PR title includes a link to the relevant issue
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted
  • The test suite is passing
  • Corresponding changes to the documentation have been made

@vercel
Copy link

vercel bot commented Sep 25, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/cf95vglif
✅ Preview: https://test-studio-git-fix-authless-start.sanity-io.vercel.app

Copy link
Member

@kmelve kmelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rexxars rexxars merged commit 2f5b089 into next Sep 25, 2020
@rexxars rexxars deleted the fix-authless-start branch September 25, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants