Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[field, form-builder] fix text overflow issue in diff component and field overflow modals #2079

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

vicmeow
Copy link
Contributor

@vicmeow vicmeow commented Oct 19, 2020

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)

Does this change require a documentation update? (Check one)

  • Yes
  • No

Current behavior

Content in a field overflows the fieldset width:
Screenshot 2020-10-19 at 16 12 26

Content in a field overflows the diff component:
Screenshot 2020-10-19 at 16 12 53

Description

This fixes the overflow issue in both cases. Path to test it in /test/desk/blocksTest;6f5befe8-d84a-4b2a-95f3-eae63bbce31f%2Csince%3D%40lastPublished under recursive blocks and in the changes panel.

Note for release

Checklist

  • I have read the Contributing Guidelines
  • The PR title is appropriately formatted: [some-package] PR title (#123)
  • The code is linted

@vercel
Copy link

vercel bot commented Oct 19, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/f1apxmj4p
✅ Preview: https://test-studio-git-fix-overflow.sanity-io.vercel.app

@vicmeow vicmeow merged commit f4b1e6e into next Oct 20, 2020
@vicmeow vicmeow deleted the fix-overflow branch October 20, 2020 08:53
vicmeow added a commit that referenced this pull request Oct 20, 2020
* [field] fix fields in fieldsets overflowing container width

* [field] fix text in diff component overflowing its container

* [form-builder] fix long title in array item overflow from overflow: hidden to min-width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants