[desk-tool] Scroll to nearest block if on focus path change #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change (check at least one)
Does this change require a documentation update? (Check one)
Current behavior
Scrolls to top of the element containing the first segment of the focus path.
Description
When you have a portable text field at the bottom of object and have not yet focused any element in the form, then click the "activate" handler on it, it scrolls to the top of the form. This is caused by the editor attempting to scroll to the top of the first segment in the focus path (the object). Previously we scrolled to the center, which meant we sometime scrolled past the field (such as with a large form and clicking the first field). This PR scrolls to the nearest point, which seems more correct at least.
I'm still not sure I feel this is the right solution, but I can't quite remember why we wanted to scroll in the first place.
Note for release
Checklist
[some-package] PR title (#123)