Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Move the preview package into base #2212

Merged
merged 1 commit into from Jan 12, 2021
Merged

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 8, 2021

Type of change (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or update to documentation)
  • Maintenance
  • Other, please describe:

Does this change require a documentation update? (Check one)

  • Yes
  • No

Description

This moves the @sanity/preview package into @sanity/base

This package is never (AFAIK) used standalone, but rather imported via part:@sanity/base/preview, so merging this should be fairly low risk in terms of breaking existing functionality.

Note for release
N/A

@vercel
Copy link

vercel bot commented Jan 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sanity-io/test-studio/i3f97gfay
✅ Preview: https://test-studio-git-move-preview-into-base.sanity-io.vercel.app

Copy link
Member

@mariuslundgard mariuslundgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@bjoerge bjoerge merged commit 8a65d25 into next Jan 12, 2021
@bjoerge bjoerge deleted the move-preview-into-base branch January 12, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants