Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Webpack 3 #224

Merged
merged 2 commits into from
Oct 5, 2017
Merged

Upgrade to Webpack 3 #224

merged 2 commits into from
Oct 5, 2017

Conversation

rexxars
Copy link
Member

@rexxars rexxars commented Oct 2, 2017

This PR upgrades the build infrastructure to use webpack 3 and the latest version of postcss.

It also includes @bjoerge's work on upgrading storybook and makes the necessary changes for it to
work in webpack 3 context.

This is a very big change infrastructure-wise, and is not something I want to merge into next without testing it thoroughly. I suppose the logical next step would be to publish a canary build that we could test various projects with, in both a development and a build setting and see if it works as expected.

Thoughts?

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just fantastic! Great work! 👏 🥇

Yeah, lets release a canary from current next after merge and try it out in a couple of studios.

@rexxars
Copy link
Member Author

rexxars commented Oct 2, 2017

I'm thinking we should probably release from this branch directly in order to keep next clean and releasable.

@bjoerge
Copy link
Member

bjoerge commented Oct 2, 2017

Yeah, thats probably safer 👍

@rexxars
Copy link
Member Author

rexxars commented Oct 2, 2017

Published as 0.115.0-alpha.d2d05de5

@rexxars rexxars merged commit 1d138e8 into next Oct 5, 2017
@rexxars rexxars deleted the webpack-3 branch October 5, 2017 14:17
rexxars added a commit that referenced this pull request Oct 6, 2017
bjoerge pushed a commit that referenced this pull request Oct 11, 2017
bjoerge pushed a commit that referenced this pull request Oct 11, 2017
bjoerge pushed a commit that referenced this pull request Oct 12, 2017
bjoerge pushed a commit that referenced this pull request Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants