[import] Allow importing from array #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
requested changes
Oct 3, 2017
| @@ -14,17 +15,22 @@ const { | |||
| strengthenReferences | |||
| } = require('./references') | |||
|
|
|||
| async function importFromStream(stream, opts) { | |||
| const options = validateOptions(stream, opts) | |||
| async function importFromStream(input, opts) { | |||
There was a problem hiding this comment.
Perhaps this should be renamed to better reflect that it takes a mixed input?
| throw new Error( | ||
| 'Stream does not seem to be a readable stream - no "pipe" method found' | ||
| ) | ||
| if (typeof input.pipe !== 'function' && !Array.isArray(input)) { |
There was a problem hiding this comment.
Maybe protect against undefined/null as input here too?
bjoerge
approved these changes
Oct 4, 2017
rexxars
added a commit
that referenced
this pull request
Oct 6, 2017
bjoerge
pushed a commit
that referenced
this pull request
Oct 11, 2017
bjoerge
pushed a commit
that referenced
this pull request
Oct 11, 2017
bjoerge
pushed a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the import module only accepts a stream. Having to wrap an array of documents in a stream feels weird and unnecessary. This PR ensures that you can call the import with either a stream or an array of documents.