[chore] Tie perf run results to hardware profile to get more comparable results #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running the perf tests in a github action, the hardware of the VM you get has some variations in cpu speed. This PR creates a hardware profile for each variation and ties the perf test result to the hardware profile it was ran in. This gives us more comparable results for similar hardware profiles.
In addition this PR adds a perf summary document that we use to track results of perf runs for a given hardware profile (as of this PR only the most recent 200 results are kept)
What to review
See it in action here:
https://perf-studio-f6m14jgdv.sanity.build/desk
Notes for release
N/A