[form-builder] Simplify input resolving #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoerge
added a commit
that referenced
this pull request
Oct 5, 2017
rexxars
pushed a commit
that referenced
this pull request
Oct 6, 2017
bjoerge
added a commit
that referenced
this pull request
Oct 11, 2017
bjoerge
added a commit
that referenced
this pull request
Oct 11, 2017
bjoerge
added a commit
that referenced
this pull request
Oct 12, 2017
bjoerge
added a commit
that referenced
this pull request
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, resolving which input to use for which type was done at several levels (we had a default resolver in the form-builder, and another resolver in the sanity layer) and it became quite hard to figure out what happened where.
This patch moves most of the input resolving logic to the same place (the sanity layer), so it's (hopefully) a bit easier to reason about it now.
This fix is not really related to the batch-upload feature, but it fixes an bug that I accidentally introduced in that branch, so I suggest we merge this into the patch-upload branch before merging it into next.