[schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default preview title for images
|
I also updated the schemas to better reflect what we actually store in the asset documents. Let me know if I've missed something. |
rexxars
pushed a commit
that referenced
this pull request
Oct 6, 2017
…s default preview title for images (#235) * [schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images * [base] Update schema definitions for assets * [base] Give the asset types better titles
bjoerge
added a commit
that referenced
this pull request
Oct 11, 2017
…s default preview title for images (#235) * [schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images * [base] Update schema definitions for assets * [base] Give the asset types better titles
bjoerge
added a commit
that referenced
this pull request
Oct 11, 2017
…s default preview title for images (#235) * [schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images * [base] Update schema definitions for assets * [base] Give the asset types better titles
bjoerge
added a commit
that referenced
this pull request
Oct 12, 2017
…s default preview title for images (#235) * [schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images * [base] Update schema definitions for assets * [base] Give the asset types better titles
bjoerge
added a commit
that referenced
this pull request
Oct 12, 2017
…s default preview title for images (#235) * [schema] Fix wrong asset type names and use asset.originalFilename as default preview title for images * [base] Update schema definitions for assets * [base] Give the asset types better titles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we are prefixing the type of asset documents with
sanity.. Found a few places that did not follow this convention.This patch:
sanity.fileAssettosanity.sanityAssetoriginalFilenameto the internal schema definition for imageAssets and fileAssetsasset.originalFilenameas default preview title on images