Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc uploader infrastructure tweaks #241

Merged
merged 2 commits into from
Oct 6, 2017

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 6, 2017

This adds the file name and the mime type to the _upload key on values that are currently being uploaded and renames the progress key from percent to progress (a number between 0 and 100).

Also includes a few flow type tweaks

@bjoerge bjoerge requested a review from rexxars October 6, 2017 15:02
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjoerge bjoerge merged commit 54d2f19 into next Oct 6, 2017
@bjoerge bjoerge deleted the refactor/uploader-infrastructure-tweaks branch October 6, 2017 15:11
bjoerge added a commit that referenced this pull request Oct 11, 2017
* [form-builder] Misc. minor adjustments uploader infrastructure

* [form-builder] Rename key for tracking upload progress from 'percent' to 'progress', add file name and type to upload status
bjoerge added a commit that referenced this pull request Oct 11, 2017
* [form-builder] Misc. minor adjustments uploader infrastructure

* [form-builder] Rename key for tracking upload progress from 'percent' to 'progress', add file name and type to upload status
bjoerge added a commit that referenced this pull request Oct 12, 2017
* [form-builder] Misc. minor adjustments uploader infrastructure

* [form-builder] Rename key for tracking upload progress from 'percent' to 'progress', add file name and type to upload status
bjoerge added a commit that referenced this pull request Oct 12, 2017
* [form-builder] Misc. minor adjustments uploader infrastructure

* [form-builder] Rename key for tracking upload progress from 'percent' to 'progress', add file name and type to upload status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants