fix: use portal for validation menu #2425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the validation menu open in a portal. Fixes issue where it got hidden behind the fullscreen Portable Text Editor
|
This pull request is being automatically deployed with Vercel (learn more). test-studio – ./🔍 Inspect: https://vercel.com/sanity-io/test-studio/7pqnZSAv22r6kXuq3S4fpBTk8qX3 perf-studio – ./🔍 Inspect: https://vercel.com/sanity-io/perf-studio/BBU5XLCjYM8BBCvo3HWdDbAndStz |
mariuslundgard
approved these changes
Apr 7, 2021
bjoerge
added a commit
that referenced
this pull request
Apr 8, 2021
This makes the validation menu open in a portal. Fixes issue where it got hidden behind the fullscreen Portable Text Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the validation menu open in a portal, fixes an issue where it got hidden behind the fullscreen Portable Text Editor.
What to review
Open or create a document that has a portable text editor and also validation errors. Open portable text editor in fullscreen. See that the validation menu is displayed on top and doesn't get layered behind the portable text editor.
Notes for release