Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field): fix z-index issues of tooltip and revert dialog #2449

Merged
merged 2 commits into from
Apr 28, 2021

Conversation

mariuslundgard
Copy link
Member

Description

  • The poppers (dialog and tooltip) in @sanity/field now use the LegacyLayerProvider to set the z-offset to a higher number than the poppers in the @sanity/form-builder.
  • This fixes the issues by making sure that the revert changes dialog is always on top of the form builder, even when viewing a deeply nested array item.

What to review

  • Open a document with deeply nested array items (2 level or deeper).
  • Edit a field in a deeply nested array item.
  • Click the Revert changes button below the changed field, and make sure the dialog is available (on both wide and narrow screens).

Notes for release

  • Fixes a z-index issue with revert changes dialogs.

@vercel
Copy link

vercel bot commented Apr 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/Fj4NZdFdwnBUdZycyHyCmnZmavxz
✅ Preview: https://test-studio-git-bug-ch8188field-poppers-z-index.sanity.build

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/9Lp3nvDvNgPSKETHkcTwh3zAuG8R
✅ Preview: https://perf-studio-git-bug-ch8188field-poppers-z-index.sanity.build

Copy link
Member

@bjoerge bjoerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mariuslundgard mariuslundgard merged commit ba32ea1 into next Apr 28, 2021
@mariuslundgard mariuslundgard deleted the bug/ch8188/field-poppers-z-index branch April 28, 2021 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants