Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[default-layout] Close search on select and escape #262

Merged
merged 1 commit into from
Oct 11, 2017

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Oct 11, 2017

This closes the search suggestions on Escape and when clicking an element. It also fixes a bug causing focus not being set on first field when editing document.

@bjoerge bjoerge requested a review from rexxars October 11, 2017 19:51
Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the onClick handler also called when using keyboard (Enter) to select?
Looks good!

@bjoerge bjoerge merged commit 4c3904f into next Oct 11, 2017
@bjoerge bjoerge deleted the fix/close-search-on-escape branch October 11, 2017 20:10
@bjoerge
Copy link
Member Author

bjoerge commented Oct 11, 2017

Is the onClick handler also called when using keyboard (Enter) to select?

Yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants