fix: use correct width/height for preview images, scale by dpr #2728
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recently we changed the default previews to be a bit smaller (35px vs 40px). The thumbnail image that we are fetching is however still 80px, which creates a slightly unclear thumbnail when scaled down, since it's not a factor of 2 larger.
This changes the dimensions to 35 pixels which is the actually correct size, and passes a
dpr
property to the image URL library based on what the device reports as it's DPR (through thewindow.devicePixelRatio
property, rounded down and capped at 3).This makes the thumbnails clearer on regular screens (because the size is correct - 35px vs 40px) and clearer on high-DPI monitors such as Mac retina displays and mobile phone displays.
Current (1 DPR display):
With this change (1 DPR display):
What to review
Notes for release