Feature: allow global logins with the default-login #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skogsmaskin
force-pushed
the
feature/default-login-allow-global
branch
from
6e42001
to
5fad200
Compare
bjoerge
pushed a commit
that referenced
this pull request
Oct 19, 2017
* [default-login] Add dev-dependency making it possible to npm link the module * [default-login] Allow global logins with a proper configured client * [default-login] Allow tweaking the login dialog content through props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to reuse the default-login plugin in other contexts which deals with global users (like the new manage-app).
Bonus: make it possible to
npm linkthe module from the mono-repo (add missing dev-dependencybabel-preset-env) for development purposes.