Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: run build before publish-tag #2737

Merged
merged 1 commit into from
Sep 3, 2021

Conversation

ricokahler
Copy link
Contributor

@ricokahler ricokahler commented Sep 3, 2021

Description

I had to run the build prior to running publish tag and that might be a missed step in the future so this may help.

notice that npm run publish runs the build prior too

What to review

Check the logic; try the command

@vercel
Copy link

vercel bot commented Sep 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

perf-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/perf-studio/6kPXYm4kYz341mjejGFMDmpFs1bq
✅ Preview: https://perf-studio-git-chore-run-build-before-publish-tag.sanity.build

test-studio – ./

🔍 Inspect: https://vercel.com/sanity-io/test-studio/3rS8wseU9ibqm2tbXwWoi8p7Quxi
✅ Preview: https://test-studio-git-chore-run-build-before-publish-tag.sanity.build

Copy link
Member

@rexxars rexxars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have to do a rebase on this one, but the change seems logical - I assume this is an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants